Skip to content

revert(virtual-core): "notify framework when count changes"#1112

Merged
piecyk merged 2 commits intoTanStack:mainfrom
piecyk:revert/1085
Jan 7, 2026
Merged

revert(virtual-core): "notify framework when count changes"#1112
piecyk merged 2 commits intoTanStack:mainfrom
piecyk:revert/1085

Conversation

@piecyk
Copy link
Collaborator

@piecyk piecyk commented Jan 7, 2026 •
edited
Loading

🎯 Changes

This reverts the infinite re-rendering issue introduced in #1085

The fix was unnecessary - getMeasurements() already invalidates on count changes via getMeasurementOptions() dependency. Test confirms getTotalSize() returns fresh values without manual notifications.

fixes #1092

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: baa7baf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@tanstack/virtual-core Patch
@tanstack/angular-virtual Patch
@tanstack/lit-virtual Patch
@tanstack/react-virtual Patch
@tanstack/solid-virtual Patch
@tanstack/svelte-virtual Patch
@tanstack/vue-virtual Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Jan 7, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit baa7baf

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 4s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 16s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-07 20:52:16 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 7, 2026 •
edited
Loading

More templates

@tanstack/angular-virtual

npm i https://pkg.pr.new/@tanstack/angular-virtual@1112

@tanstack/lit-virtual

npm i https://pkg.pr.new/@tanstack/lit-virtual@1112

@tanstack/react-virtual

npm i https://pkg.pr.new/@tanstack/react-virtual@1112

@tanstack/solid-virtual

npm i https://pkg.pr.new/@tanstack/solid-virtual@1112

@tanstack/svelte-virtual

npm i https://pkg.pr.new/@tanstack/svelte-virtual@1112

@tanstack/virtual-core

npm i https://pkg.pr.new/@tanstack/virtual-core@1112

@tanstack/vue-virtual

npm i https://pkg.pr.new/@tanstack/vue-virtual@1112

commit: baa7baf

@piecyk piecyk mentioned this pull request Jan 7, 2026
Closed
2 tasks
@piecyk piecyk merged commit 9067574 into TanStack:main Jan 7, 2026
5 checks passed
@github-actions github-actions bot mentioned this pull request Jan 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

React v3.13.13 causes infinite re-renders after setting getItemKey()

1 participant

@piecyk